Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add admin filters #516

Merged
merged 1 commit into from Jun 19, 2020
Merged

Add admin filters #516

merged 1 commit into from Jun 19, 2020

Conversation

core23
Copy link
Member

@core23 core23 commented Mar 16, 2020 •
edited by greg0ire

Subject

Adds reuseable filters that can respect the admins classification context.

I am targeting this branch, because this feature is BC.

Changelog

### Added
- Added `CategoryFilter` for admin lists
- Added `CollectionFilter` for admin lists

@core23 core23 requested a review from a team March 16, 2020 17:05
@core23 core23 force-pushed the filters branch 2 times, most recently from a101cd5 to 124bfd1 Compare April 3, 2020 11:57
@core23 core23 force-pushed the filters branch 3 times, most recently from 88a998f to 7b0645f Compare April 3, 2020 13:53
phansys
phansys requested changes Apr 6, 2020
View reviewed changes
src/Admin/Filter/CategoryFilter.php Outdated Show resolved Hide resolved
tests/Admin/Filter/QueryBuilder.php Outdated Show resolved Hide resolved
greg0ire
greg0ire reviewed Apr 6, 2020
View reviewed changes
src/Admin/Filter/CategoryFilter.php Outdated Show resolved Hide resolved
tests/Admin/Filter/CollectionFilterTest.php Outdated Show resolved Hide resolved
tests/Admin/Filter/QueryBuilder.php Show resolved Hide resolved
@core23 core23 force-pushed the filters branch 3 times, most recently from ede72ed to dc55339 Compare June 2, 2020 15:23
@core23 core23 requested review from phansys and greg0ire June 2, 2020 15:32
@core23 core23 requested a review from a team June 12, 2020 19:46
@core23
Copy link
Member Author

core23 commented Jun 16, 2020

Please review @sonata-project/contributors

@core23 core23 requested a review from a team June 18, 2020 16:24
@core23 core23 closed this Jun 19, 2020
@core23 core23 reopened this Jun 19, 2020
@core23 core23 merged commit 084d273 into sonata-project:3.x Jun 19, 2020
@core23 core23 deleted the filters branch June 19, 2020 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet left review comments

@greg0ire greg0ire greg0ire approved these changes

@phansys phansys phansys approved these changes

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
feature minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@core23 @greg0ire @OskarStark @phansys @VincentLanglet