-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Lexer query error #519
Conversation
Can you add a test for the bug @core23 ? |
I'm not sure if this makes much sense, because these things are some kind of doctrine builder |
The SonataDoctrineOrmAdminBundle use is own mock and check the query It's possible to use a database and check for the results. In this case, the query executed was failing and we couldn't detect this. If someone modify this code, it can be broken again. There should be a way to avoid regression... |
Done @VincentLanglet |
Woops, tests are failing @core23 |
I think you should use the syntax
When there is multiple calls |
db963a0
to
c667d94
Compare
We need this one to fix the tests :/ |
This is strange, even after a fresh rebase |
Yeah very. I restarted the job, and it passes now… weird. |
Subject
There was an lexer error in my previous PR:
This results in an invalid query:
I am targeting this branch, because {reason}.
Fixes #517
Changelog