Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CoreBundle optional #531

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Make CoreBundle optional #531

merged 2 commits into from
Jun 12, 2020

Conversation

wbloszyk
Copy link
Member

@wbloszyk wbloszyk commented May 20, 2020 •
edited by jordisala1991

Subject

I am targeting this branch, because this changes are BC.

Part of sonata-project/dev-kit#697

Changelog

### Removed
- SonataCoreBundle dependencies
- Support for Symfony < 4.3

@wbloszyk wbloszyk mentioned this pull request May 20, 2020
Closed
31 tasks
@SonataCI
Copy link
Collaborator

SonataCI commented Jun 2, 2020

Could you please rebase your PR and fix merge conflicts?

@core23 core23 mentioned this pull request Jun 2, 2020
Closed
@wbloszyk wbloszyk force-pushed the drop_core_in_3 branch 3 times, most recently from 6e4e0ed to ef2d976 Compare June 4, 2020 21:26
@wbloszyk wbloszyk closed this Jun 9, 2020
@jordisala1991
Copy link
Member

Why you closed this one?

@wbloszyk
Copy link
Member Author

Change in this bundle will be more harder. I focus on admin and block first. This will be reopen soon.

@wbloszyk wbloszyk reopened this Jun 11, 2020
@wbloszyk wbloszyk marked this pull request as ready for review June 11, 2020 17:27
core23
core23 previously approved these changes Jun 11, 2020
View reviewed changes
jordisala1991
jordisala1991 previously approved these changes Jun 11, 2020
View reviewed changes
@jordisala1991
Copy link
Member

prefer-lowest build is failing, maybe you can try upgrading a bit those dependencies trying to find which one makes everything slow

@jordisala1991
Copy link
Member

Maybe remove sf 3.4 and leave only 4.3 could help

@wbloszyk wbloszyk dismissed stale reviews from jordisala1991 and core23 via 039d29e June 11, 2020 22:40
@jordisala1991 jordisala1991 requested a review from a team June 12, 2020 06:09
@jordisala1991 jordisala1991 merged commit d24b74e into sonata-project:3.x Jun 12, 2020
@jordisala1991
Copy link
Member

Thank you @wbloszyk

@wbloszyk wbloszyk deleted the drop_core_in_3 branch June 12, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@core23 core23 Awaiting requested review from core23

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wbloszyk @SonataCI @jordisala1991 @core23 @VincentLanglet