Make admin dependency optional for block rendering #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core23
force-pushed
the
optional-admin-in-block
branch
from
b290b5c
to
6164c57
Compare
jordisala1991
approved these changes
Aug 22, 2020
No, they are abstract classes that are only used on our other projects (e.g. NewsBundle) |
VincentLanglet
approved these changes
Aug 22, 2020
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
The admin dependency is optional for this bundle, however the blocks still depend on an admin.
This PR makes the admin dependency optional, if you just want to use block rendering (
BlockInterface::execute) without editing it.I am targeting this branch, because this is BC.
Changelog