Fix loading CategoryFilter items #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.x #567 +/- ##
=========================================
Coverage 60.26% 60.26%
Complexity 442 442
=========================================
Files 43 43
Lines 1427 1427
=========================================
Hits 860 860
Misses 567 567
Continue to review full report at Codecov.
|
core23
commented
Aug 29, 2020
| @@ -20,7 +20,7 @@ | |||
| /** | |||
| * @method PagerInterface getRootCategoriesPager(int $page = 1, int $limit = 25, array $criteria = []) | |||
| * @method PagerInterface getSubCategoriesPager(int $categoryId, int $page = 1, int $limit = 25, array $criteria = []) | |||
| * @method CategoryInterface[] getRootCategoriesForContext(ContextInterface|string|null $context) | |||
| * @method CategoryInterface[] getRootCategoriesForContext(ContextInterface|null $context) | |||
There was a problem hiding this comment.
jordisala1991
previously approved these changes
Aug 30, 2020
VincentLanglet
previously approved these changes
Aug 30, 2020
core23
dismissed stale reviews from VincentLanglet and jordisala1991
via
2c1283b
core23
force-pushed
the
fix-filter
branch
4 times, most recently
from
d35f7e5
to
96a318f
Compare
Done |
VincentLanglet
previously approved these changes
Sep 4, 2020
core23
force-pushed
the
fix-filter
branch
3 times, most recently
from
b02f7f8
to
320c47c
Compare
VincentLanglet
approved these changes
Sep 4, 2020
jordisala1991
approved these changes
Sep 4, 2020
Merged
franmomu
added a commit
to franmomu/SonataClassificationBundle
that referenced
this pull request
Sep 6, 2020
In sonata-project#567 the tests introduced throw some warnings because the interface does not have the mocked method.
jordisala1991
pushed a commit
that referenced
this pull request
Sep 16, 2020
In #567 the tests introduced throw some warnings because the interface does not have the mocked method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
The filter was calling the wrong method. The called method does allow passing a string value as a parameter.
I am targeting this branch, because this is a bugfix.
Changelog