Update conflict constraint for "nelmio/api-doc-bundle" in order to allow version 3 #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
FlintCIBot
reviewed
Sep 2, 2020
FlintCIBot
reviewed
Sep 2, 2020
FlintCIBot
reviewed
Sep 2, 2020
wbloszyk
force-pushed
the
nelmio_3
branch
3 times, most recently
from
7a3055f
to
59804e5
Compare
phansys
requested changes
Sep 6, 2020
phansys
reviewed
Sep 6, 2020
greg0ire
reviewed
Sep 6, 2020
phansys
requested changes
Sep 12, 2020
| * @SWG\Response( | ||
| * response="200", | ||
| * description="Returned when successful", | ||
| * @SWG\Schema(ref=@Model(type="Sonata\DatagridBundle\Pager\PagerInterface")) |
There was a problem hiding this comment.
IMO, we could use the ::class pseudo-constant where possible.
Suggested change
| * @SWG\Schema(ref=@Model(type="Sonata\DatagridBundle\Pager\PagerInterface")) | |
| * @SWG\Schema(ref=@Model(type=Sonata\DatagridBundle\Pager\PagerInterface::class)) |
There was a problem hiding this comment.
This I will do in next PR (also models should be fix/improve in swagger).
…low version 3 Update docs/reference/api.rst Co-authored-by: Javier Spagnoletti <phansys@gmail.com> Update docs/reference/api.rst Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
phansys
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Update conflict constraint for "nelmio/api-doc-bundle" in order to allow version 3.
I am targeting this branch, because these changes almost respect BC (with one, very little BC-break potential).
Changelog