Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump PHPStan level to 3 #726

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Bump PHPStan level to 3 #726

merged 1 commit into from
Sep 9, 2021

Conversation

phansys
Copy link
Member

@phansys phansys commented Sep 9, 2021 •
edited

Subject

Bump PHPStan level to 3.

I am targeting this branch, because these changes respect BC.

Changelog

### Fixed
- Several wrong types in arguments and return declarations.

To do

  • Fix the remaining issues under the Sonata\ClassificationBundle\Controller\ namespace.

@phansys phansys marked this pull request as ready for review September 9, 2021 12:16
@phansys phansys requested a review from a team September 9, 2021 12:16
@phansys phansys requested review from franmomu, jordisala1991 and a team September 9, 2021 12:33
franmomu
franmomu approved these changes Sep 9, 2021
View reviewed changes
src/Block/Service/AbstractClassificationBlockService.php
*/
final protected function getFormAdminType(FormMapper $formMapper, AdminInterface $admin, $formField, $field, $fieldOptions = [], $adminOptions = [])
final protected function getFormAdminType(FormMapper $formMapper, AdminInterface $admin, $formField, $field, $fieldOptions = [], $adminOptions = []): FormBuilderInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add also parameter type declarations I guess

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I'll try to add them in next PRs.
Thank you.

@phansys phansys merged commit c055165 into sonata-project:3.x Sep 9, 2021
@phansys phansys deleted the phpstan branch September 9, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franmomu franmomu franmomu approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@jordisala1991 jordisala1991 Awaiting requested review from jordisala1991

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phansys @franmomu @VincentLanglet