Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add finals #738

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Add finals #738

merged 2 commits into from
Oct 6, 2021

Conversation

wbloszyk
Copy link
Member

@wbloszyk wbloszyk commented Oct 6, 2021 •
edited

Subject

I am targeting this branch, because these changes should be done in 3.x.

Changelog

### Deprecated
- Extending classes marked as final:
    - `Sonata\ClassificationBundle\Admin\CategoryAdmin`
    - `Sonata\ClassificationBundle\Admin\CollectionAdmin`
    - `Sonata\ClassificationBundle\Admin\ContextAdmin`
    - `Sonata\ClassificationBundle\Admin\TagAdmin`
    - `Sonata\ClassificationBundle\Command\FixContextCommand`
    - `Sonata\ClassificationBundle\Controller\CategoryAdminController`
    - `Sonata\ClassificationBundle\DependencyInjection\Configuration`
    - `Sonata\ClassificationBundle\DependencyInjection\SonataClassificationExtension`
    - `Sonata\ClassificationBundle\Document\CategoryManager`
    - `Sonata\ClassificationBundle\Document\CollectionManager`
    - `Sonata\ClassificationBundle\Document\TagManager`
    - `Sonata\ClassificationBundle\Entity\CategoryManager`
    - `Sonata\ClassificationBundle\Entity\CollectionManager`
    - `Sonata\ClassificationBundle\Entity\ContextManager`
    - `Sonata\ClassificationBundle\Entity\TagManager`
    - `Sonata\ClassificationBundle\Form\Type\Category\SelectorType`
    - `Sonata\ClassificationBundle\SonataClassificationBundle`

@wbloszyk wbloszyk requested a review from a team October 6, 2021 12:14
@wbloszyk wbloszyk requested a review from a team October 6, 2021 13:04
phansys
phansys reviewed Oct 6, 2021
View reviewed changes
Copy link
Member

@phansys phansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, since these annotations trigger deprecations, this PR requires an upgrade note.

@wbloszyk wbloszyk merged commit 664cceb into sonata-project:3.x Oct 6, 2021
@wbloszyk wbloszyk deleted the add_finals branch October 6, 2021 15:18
@wbloszyk
Copy link
Member Author

wbloszyk commented Oct 6, 2021

IMO, since these annotations trigger deprecations, this PR requires an upgrade note.

#739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansys phansys phansys approved these changes

@core23 core23 core23 approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
minor Needs: Upgrade note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wbloszyk @phansys @core23 @VincentLanglet