Remove call to unknown method #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
previously approved these changes
Oct 28, 2021
VincentLanglet
requested changes
Oct 28, 2021
| @@ -57,7 +57,6 @@ final protected function getFormAdminType(FormMapper $formMapper, AdminInterface | |||
|
|
|||
| $fieldDescription = $admin->createFieldDescription($field, $adminOptions); | |||
| $fieldDescription->setAssociationAdmin($admin); | |||
| $fieldDescription->setAdmin($formMapper->getAdmin()); | |||
There was a problem hiding this comment.
Can the FormMapper namespace be changed to the BlockBundle one ?
core23
force-pushed
the
block-entity-type
branch
from
178eb47
to
f744d54
Compare
VincentLanglet
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
We don't need this call, as the admin is set via https://github.com/sonata-project/SonataAdminBundle/blob/ab9f4e0771e303628d0ea3fe99b0b56cb7b07895/src/Admin/AbstractAdmin.php#L1824
Changelog