Add Symfony 6 support #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires: sonata-project/SonataDoctrineMongoDBAdminBundle#699 Edit: Done, it is merged. |
This was referenced Nov 26, 2021
jordisala1991
force-pushed
the
feature/symfony-6
branch
from
c7d2d43
to
50a1181
Compare
|
Some code need to be fixed. |
|
Maybe after this one we can do the 4.0.0 final release? @core23 |
VincentLanglet
approved these changes
Nov 26, 2021
core23
reviewed
Nov 26, 2021
| @@ -74,14 +74,14 @@ public function listAction(Request $request): Response | |||
|
|
|||
| public function treeAction(Request $request): Response | |||
| { | |||
| $categoryManager = $this->get('sonata.classification.manager.category'); | |||
| $categoryManager = $this->container->get('sonata.classification.manager.category'); | |||
There was a problem hiding this comment.
Do we have a test that covers this action?
There was a problem hiding this comment.
I dont know, but the get method was deprecated on 5.4, and removed on 6.0
Edit: I would say probably because test were failing without this change
There was a problem hiding this comment.
This is not related to this PR, but we had some problem with some admin actions.
I'll try to add some basic tests to cover this this before releasing the stable release.
core23
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this cannot be done on lower branch.
Part of: sonata-project/dev-kit#1675
Dev-kit PR: sonata-project/dev-kit#1786
Changelog