Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Mark package as abandoned #177

Merged
merged 1 commit into from Sep 16, 2021
Merged

Mark package as abandoned #177

merged 1 commit into from Sep 16, 2021

Conversation

core23
Copy link
Member

@core23 core23 commented Sep 16, 2021

@core23 core23 requested a review from a team September 16, 2021 12:50
@VincentLanglet
Copy link
Member

I'm more concern about this one. What was the purpose and what should we do with this code ?
Isn't it useful for SonataMedia and/or SonataClassification ?

@core23
Copy link
Member Author

core23 commented Sep 16, 2021

Long time ago... there was a circular dependency between the classification and the media bundle, so I moved most classification stuff from the media bundle to this repo.

It was just a POC that no one ever used.

@phansys
Copy link
Member

phansys commented Sep 16, 2021

Long time ago... there was a circular dependency between the classification and the media bundle

That was a pain 😄

Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@core23 core23 merged commit dad05a9 into sonata-project:master Sep 16, 2021
@VincentLanglet
Copy link
Member

Not sure it's even worth to open an issue like sonata-project/SonataDoctrinePhpcrAdminBundle#600 for this bundle

@core23 core23 deleted the abandoned branch September 16, 2021 17:33
@franmomu
Copy link
Member

The only thing is that next major version of ClassificationBundle won't have a way to connect with MediaBundle, no (maybe is not necessary)? I've never used them, just based on what I remember when I had to modify this bundle.

@core23
Copy link
Member Author

core23 commented Sep 16, 2021

Done #178

@VincentLanglet
Copy link
Member

ClassificationBundle is in the require-dev of MediaBundle, and I had to work on it to help @jordisala1991 on Media, so I would say it's still work correctly.

@franmomu
Copy link
Member

👍 I don't know how they work TBH, I remembered sonata-project/SonataClassificationBundle#196, so it was just in case the code was useful.

@jordisala1991
Copy link
Member

ClassificationBundle is in the require-dev of MediaBundle, and I had to work on it to help @jordisala1991 on Media, so I would say it's still work correctly.

ClassificationBundle will stay. But it wont be circular dependency anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants