Manual merge #586
Manual merge #586
Conversation
* Deprecated doctrine classes * Added "legacy" tag to tests * Externalize fixtures * Improved deprecation message
…nstead of finishView (sonata-project#543)
|
The build breaks with:
I don't understand why the build would pass on 3.x |
|
Ah I understand, it's about the "strict types" declaration. |
| @@ -39,3 +39,8 @@ This package is available under the [MIT license](LICENSE). | |||
| [coveralls_stable_link]: https://coveralls.io/github/sonata-project/SonataCoreBundle?branch=3.x | |||
| [coveralls_unstable_badge]: https://coveralls.io/repos/github/sonata-project/SonataCoreBundle/badge.svg?branch=master | |||
| [coveralls_unstable_link]: https://coveralls.io/github/sonata-project/SonataCoreBundle?branch=master | |||
|
|
|||
| [scrutinizer_stable_badge]: https://scrutinizer-ci.com/g/sonata-project/SonataCoreBundle/badges/quality-score.png?b=3.x | |||
There was a problem hiding this comment.
Should it be master?
There was a problem hiding this comment.
yes and it is currently available, maybe your branch was outdated? 🤔
There was a problem hiding this comment.
ah sorry, no it isn't available in master, but yes it should be master in the URL
There was a problem hiding this comment.
But it says "stable", and master is unstable.
There was a problem hiding this comment.
argh you are right, sorry for confusing.
Everything is fine 👍
| sphinx_rtd_theme |
There was a problem hiding this comment.
the dev kit changes should be available as they get executed against master separately
There was a problem hiding this comment.
What should I do? Won't dev-kit fix anything that goes wrong?
There was a problem hiding this comment.
Ofc it will, but only when it gets executed again
Forcing it to null: - is useless; - breaks if you use the "strict types" feature of php 7.
No description provided.