Feature/batch flashmessages #657
Conversation
| {% endfor %} | ||
|
|
||
| <style> |
There was a problem hiding this comment.
I need to move this to css file (create new one)
|
Could you please rebase your PR and fix merge conflicts? |
|
Could we add a count of the messages next to the "headline"? Attention: {{ app.flashes('success') }}will clear all messages on the first consume, I think you need to use |
| position: relative; | ||
| left: calc(50% - 1rem); | ||
| } | ||
| </style> |
|
One question: I created a new |
| × | ||
| </button> | ||
| <input type="checkbox" class="read-more-state" id="toggle-more" /> | ||
| <script>$(document).ready(()=> {$('#toggle-more').iCheck('destroy')})</script> |
There was a problem hiding this comment.
I know this isn't nice but i need to disable iCheck for this case. shall i put this in the base.js file?
There was a problem hiding this comment.
If it is needed on every page, yes, otherwise, just create a new JS file?
There was a problem hiding this comment.
it is needed on every page but only for #toggle-more element
|
How gets the |
|
Sorry, I don't 😅 |
|
related to sonata-project/SonataAdminBundle#5438 |
|
So is the translation in all provided languages really necessary? Because just speak 3 of them 😄 |
|
|
||
| <style> | ||
| .read-more-state ~ .read-more-trigger:before { | ||
| content: "{{ 'more'|trans({}, 'SonataCoreBundle') }} \25bc"; |
There was a problem hiding this comment.
This style needs to stay here, otherwise this cant be translated.
|
3 languages are enough here |
| {% endfor %} | ||
|
|
||
| <style> | ||
| .read-more-state ~ .read-more-trigger:before { |
There was a problem hiding this comment.
Please remove this. You could also use JavaScript for this
There was a problem hiding this comment.
okay there you go 👍 i dont use jQuery for this just plain JS. Plain JS is much faster than jquery.
Subject
I am targeting this branch, because this is a bc.
Closes #507
Changelog
To do
morein all provided languagesLook & Feel
Before
After
Collapsed (default)
Expanded