Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

Improve core before split - CoreBundle 3.19.2 #751

Merged

Conversation

wbloszyk
Copy link
Member

@wbloszyk wbloszyk commented May 26, 2020

Subject

Allow register bridges by move aliases to compiler pass. Override CoreBundle config will throw exception about move this config to registred bridges.

I am targeting this branch, because these changes respect BC.

Changelog

### Changed
- change register aliases from bundle configuration to compiler pass
### Fixed
- fixed register CoreBundle with form and twig bridges 

This PR should be release as 3.19.2

@wbloszyk wbloszyk changed the title Improve core before split Improve core before split - CoreBundle 3.19.x May 26, 2020
@wbloszyk wbloszyk changed the title Improve core before split - CoreBundle 3.19.x Improve core before split - CoreBundle 3.19.2 May 27, 2020
@greg0ire greg0ire requested a review from a team May 27, 2020 20:39
Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we release this as 3.19.2 and not 3.20 ?

This seems more like a release than a patch to me

@VincentLanglet VincentLanglet requested a review from a team May 31, 2020 22:00
@wbloszyk
Copy link
Member Author

It can be release as 3.20 too. I will change reqiurements in feature PRs then.

@wbloszyk
Copy link
Member Author

wbloszyk commented Jun 1, 2020

@VincentLanglet I check something. This PR replace creating alias from xml files to compiler pass. It can be trait as patch or minor. Some change is already merge. Better keep it as 3.19.2 to avoid fix it in production.

@VincentLanglet VincentLanglet requested a review from a team June 1, 2020 09:00
@jordisala1991
Copy link
Member

I did a couple of PR on your fork to improve this PR, feel free to merge them or use portions of code to help finish this PR.

@wbloszyk
Copy link
Member Author

wbloszyk commented Jun 1, 2020

I have long weekend. I will back to home tomorrow. Some change look nice.

@VincentLanglet
Copy link
Member

@VincentLanglet I check something. This PR replace creating alias from xml files to compiler pass. It can be trait as patch or minor. Some change is already merge. Better keep it as 3.19.2 to avoid fix it in production.

I don't understand.

Patch is for bugfix.
Minor is for new feature.

Are you fixing a bug ?
I don't think so. You're adding new CompilerPass and you're adding deprecation.

If someone require 3.19.x. Updating automatically from 3.19.1 to 3.19.2 could break a CI because of the deprecation for example. There is certainly other possible impact.

Even if we're deprecating the bundle, we should still respect the SemVer.

@wbloszyk
Copy link
Member Author

wbloszyk commented Jun 1, 2020

I adding fix, becouse bridges exist and can't be register. It is not new feature too

@wbloszyk wbloszyk force-pushed the improve_core_before_split branch 2 times, most recently from f187765 to 200e12f Compare June 2, 2020 13:36
Improve deprecation messages
@jordisala1991 jordisala1991 reopened this Jun 2, 2020
@jordisala1991 jordisala1991 merged commit b6efcf6 into sonata-project:3.x Jun 3, 2020
@jordisala1991
Copy link
Member

Thank you @wbloszyk !

@wbloszyk wbloszyk deleted the improve_core_before_split branch June 3, 2020 12:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants