-
Notifications
You must be signed in to change notification settings - Fork 141
Improve core before split - CoreBundle 3.19.2 #751
Improve core before split - CoreBundle 3.19.2 #751
Conversation
dc888f9
to
7ebdaa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should we release this as 3.19.2 and not 3.20 ?
This seems more like a release than a patch to me
It can be release as 3.20 too. I will change reqiurements in feature PRs then. |
src/CoreBundle/DependencyInjection/Compiler/FormCompilerPass.php
Outdated
Show resolved
Hide resolved
@VincentLanglet I check something. This PR replace creating alias from xml files to compiler pass. It can be trait as patch or minor. Some change is already merge. Better keep it as 3.19.2 to avoid fix it in production. |
src/CoreBundle/DependencyInjection/Compiler/FormCompilerPass.php
Outdated
Show resolved
Hide resolved
I did a couple of PR on your fork to improve this PR, feel free to merge them or use portions of code to help finish this PR. |
I have long weekend. I will back to home tomorrow. Some change look nice. |
I don't understand. Patch is for bugfix. Are you fixing a bug ? If someone require 3.19.x. Updating automatically from 3.19.1 to 3.19.2 could break a CI because of the deprecation for example. There is certainly other possible impact. Even if we're deprecating the bundle, we should still respect the SemVer. |
I adding fix, becouse bridges exist and can't be register. It is not new feature too |
f187765
to
200e12f
Compare
src/CoreBundle/DependencyInjection/Compiler/FormCompilerPass.php
Outdated
Show resolved
Hide resolved
200e12f
to
bf948a1
Compare
Improve deprecation messages
bf948a1
to
26facae
Compare
Thank you @wbloszyk ! |
Subject
Allow register bridges by move aliases to compiler pass. Override CoreBundle config will throw exception about move this config to registred bridges.
I am targeting this branch, because these changes respect BC.
Changelog
This PR should be release as 3.19.2