Added doctrine_mongo_autocomplete model filter #137
Conversation
joshlopes
commented
May 26, 2015
joshlopes
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #138 |
| License | no |
| Doc PR | no |
…hAdmiClass on the fixFieldDescription as ORM -- Added getFieldName on Filter to respect the parents associations mappings
|
Improved the DataGrid to look more similar to ORM (including the pager tag settings etc which for now we only have one Pager) For the autocomplete to work on multiple associations i had to also change the base Filter to look on parents association and clean it up |
| case Pager::TYPE_DEFAULT: | ||
| return new Pager(); | ||
|
|
||
| // TODO: Implement a Simple page that extends Simple Pager from admin? |
|
@dunglas can you review this PR ? |
|
Any news on this? @dunglas can you please review and tell me if anything is missing ? thanks |
|
@rande any chance that you can review this yourself ? :) |
|
Kind bump |
|
@rande or @dunglas can you please check all Pulls and merge ? I have to walk with my vendors folder on my back to keep this code on my servers / projects. Would be great if you could merge / close this pull -- have been using them for 3 months now no problems whatsoever. If you think this will take to much time / will not be possible let me know and i will have to use my own forks |
|
@joshlopes can you resvole conflicts? |
| * | ||
| * @throws \RuntimeException If invalid pager type is set. | ||
| */ | ||
| protected function getPager($pagerType) |
There was a problem hiding this comment.
What's the use case of this new extension point?
There was a problem hiding this comment.
I tried to keep the same logic of MySQL PHP file for be easier to mantain both projects by just comparing them -- till common areas such this one become merged into Admin bundle
|
Can you add tests for the new code? |
Conflicts: Builder/DatagridBuilder.php Filter/ModelFilter.php composer.json
|
This is wrong, i am creating a new branch for this feature and use the master on my project as this review / test etc is taking to much time and all my work is doubled because there is major bugs that needs to be fixed on live to use this project. So -- my master branch will be the up-to-date with all features and the other minor branchs will be inserted here for this long review / test thingy.. If you are reading this and you are interested in having the features use my fork version instead. Thanks! |
