Drop old versions of php/sf #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
previously approved these changes
Oct 16, 2017
core23
force-pushed
the
patch/php-support
branch
2 times, most recently
from
1bac6c3
to
4702ba5
Compare
|
Could you please rebase your PR and fix merge conflicts? |
|
Now we can do this change again, can you rebase and fix conflicts @core23 ? |
composer.json
Outdated
| @@ -17,15 +17,15 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": "^5.3 || ^7.0", | |||
| "php": "^5.6 || ^7.1", | |||
There was a problem hiding this comment.
this should be: ^5.6 || ^7.0
core23
force-pushed
the
patch/php-support
branch
from
4702ba5
to
a9c9e70
Compare
jordisala1991
approved these changes
Nov 14, 2017
|
Please review @jlamur |
jlamur
approved these changes
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because this is BC.
Changelog