Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated twig paths #271

Merged
merged 1 commit into from Jan 6, 2018
Merged

Update deprecated twig paths #271

merged 1 commit into from Jan 6, 2018

Conversation

enleur
Copy link
Contributor

@enleur enleur commented Jan 4, 2018 •
edited

I am targeting this branch, because why not.

Changelog

### Added
- Added twig dependency

### Changed
- Replace twig paths with new naming conventions

Subject

Colon separators in twig paths is no longer recommended https://symfony.com/doc/3.3/templating/namespaced_paths.html

@enleur
Copy link
Contributor Author

enleur commented Jan 4, 2018

Didn't see #258

core23
core23 requested changes Jan 5, 2018
View reviewed changes
src/Resources/views/CRUD/edit_mongo_collection.html.twig
@@ -132,7 +132,7 @@ file that was distributed with this source code.
{% endif %}

{# include association code #}
{% include 'SonataDoctrineMongoDBAdminBundle:CRUD:edit_mongo_one_association_script.html.twig' %}
{% include '@SonataDoctrineMongoDBAdmin/CRUD/edit_mongo_one_association_script.html.twig' %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The twig dependency is missing in composer.json. Please add it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@core23 done

@jordisala1991
Copy link
Member

Note that there is also a #258 and we probably do not need all of this changes (done on the other PR)

@enleur
Copy link
Contributor Author

enleur commented Jan 5, 2018

Well, if we merge this PR in #258 he has to rebase and change twig paths to the new conventions :)

@enleur
Copy link
Contributor Author

enleur commented Jan 6, 2018

Reference to sonata-project/dev-kit#374

@greg0ire greg0ire merged commit 5ea42d7 into sonata-project:3.x Jan 6, 2018
@greg0ire
Copy link
Contributor

greg0ire commented Jan 6, 2018

Thanks @enleur !

@enleur enleur deleted the twig-paths branch January 6, 2018 19:48
@franmomu franmomu mentioned this pull request Jul 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core23 core23 core23 approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@enleur @jordisala1991 @greg0ire @core23 @OskarStark