Support doctrine/mongodb-odm ^2.x & doctrine/mongodb-odm-bundle ^4.x

[romainnorberg]

• support both version of doctrine/mongodb-odm (^1.0 || ^2.0)
  • https://github.com/doctrine/mongodb-odm/blob/master/UPGRADE-2.0.md
  • BC: Class name resolver performance optimisation doctrine/mongodb-odm#2069
• support both version of doctrine/mongodb-odm-bundle (^3.0 || ^4.0)
  • https://github.com/doctrine/DoctrineMongoDBBundle/blob/master/UPGRADE-4.0.md
• run php-cs fixer (lint CI build)
• updated FilterTypeGuesserTest

I am targeting this branch, because this is not BC.

[core23]

AFAIK you could do this on the stable branch.

WDYT @sonata-project/contributors

[OskarStark]

Yes let’s do it on the stable branch

[romainnorberg]

hello @core23 @OskarStark Thanks for reviews 👍

I don't have a lot of experience in BC management (I thought I had to target the master branch with these changes) and I am a novice in the contribution to open-source packages 😕

I'll check why CI fail

[aturki]

Hello,
Both doctrine/mongodb-odm and doctrine/mongodb-odm-bundle require PHP version 7.2 or higher. This is a BC break with the current version 3.x. Shouldn't we target the master branch instead ?

[phansys]

IMO, from a strict semver point of view, if the changes are respecting BC we could accept them regardless their dependencies; since PHP is in fact a dependency itself.
But we have some extra rules around it which disallow the drop of a security maintained PHP version on a stable branch.

[core23]

This class exists in odm 1.x and 2.x. You could support both version inside the composer.json file

[romainnorberg]

hello @core23 thanks for review.

• I updated composer.json file to support both version of mongodb-odm
• run php-cs fixer (lint CI build)
• updated FilterTypeGuesserTest -> i don't know if it's the right solution 👀

[romainnorberg]

thanks @ALL for your time & reviews

[OskarStark]

We thank you for this contribution, keep on going 👍🏻👍🏻🥳🥳