Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a link to Doctrine documentation site #1028

Merged
merged 1 commit into from Apr 7, 2020

Conversation

jorrit
Copy link
Contributor

@jorrit jorrit commented Apr 7, 2020

Subject

FieldDescription.php contained an outdated link to a Doctrine documentation page.

I am targeting this branch, because it's a comment.

Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link to 2.8 doc since we don't support 3.x ?

@jorrit
Copy link
Contributor Author

jorrit commented Apr 7, 2020

I used latest because that's what was used in the original link. 2.8 is fine by me.

@VincentLanglet
Copy link
Member

I used latest because that's what was used in the original link. 2.8 is fine by me.

Latest has one avantage, we don't have to update it. It's fine by me.

@core23 core23 merged commit 14a39b0 into sonata-project:3.x Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants