Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some deprecations about invalid values #1049

Merged
merged 1 commit into from
Jun 28, 2020

Conversation

phansys
Copy link
Member

@phansys phansys commented May 24, 2020

Subject

Add some deprecations at ModelManager and FieldDescription in order to be prepared for the next major.

I am targeting this branch, because these changes respect BC.

Changelog

### Added
- Added `FieldDescription::getTargetModel()`.

### Deprecated
- Deprecated passing `null` as argument 2 for `ModelManager::find()`;
- Deprecated passing `null` as argument 1 for `ModelManager::getNormalizedIdentifier()`;
- Deprecated passing objects which are in state 2 (new) or 4 (removed) as argument 1 for `ModelManager::getNormalizedIdentifier()`;
- Deprecated passing other type than `object` as argument 1 for `ModelManager::getUrlSafeIdentifier()`;
- Deprecated `FieldDescription::getTargetEntity()` in favor of `FieldDescription::getTargetModel()`.

To do

  • Update the tests.

core23
core23 previously approved these changes May 25, 2020
@phansys phansys changed the title Add some deprecations at ModelManager Add some deprecations about invalid values May 25, 2020
@phansys phansys requested review from core23 and a team May 25, 2020 14:12
@phansys phansys marked this pull request as ready for review May 25, 2020 14:16
core23
core23 previously approved these changes May 26, 2020
VincentLanglet
VincentLanglet previously approved these changes May 26, 2020
core23
core23 previously approved these changes May 27, 2020
VincentLanglet
VincentLanglet previously approved these changes May 27, 2020
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@phansys phansys requested a review from a team June 28, 2020 16:31
@phansys
Copy link
Member Author

phansys commented Jun 28, 2020

I've added an entry at UPGRADE-3.x.md.

VincentLanglet
VincentLanglet previously approved these changes Jun 28, 2020
core23
core23 previously approved these changes Jun 28, 2020
UPGRADE-3.x.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants