Replace deprecated 'form' type by FormType class #587
Conversation
|
Good job @soullivaneuh 👍 |
| */ | ||
| protected $datagridBuilder; | ||
| /** | ||
| * @var FormFactoryInterface|\PHPUnit_Framework_MockObject_MockObject |
There was a problem hiding this comment.
The mock implements the interface, no need to do this IMO. Plus it would be &, not |
There was a problem hiding this comment.
The mock implements the interface, no need to do this IMO.
IDE does not recognize it if you don't specify it.
Plus it would be &, not |
Where did you find that? It was always | on phpdoc comment AFAIK.
There was a problem hiding this comment.
Where did you find that? It was always | on phpdoc comment AFAIK.
AFAIK too
There was a problem hiding this comment.
Where did you find that? It was always | on phpdoc comment AFAIK.
Nowhere, but you don't mean that it's one or the other, you mean it is both, don't you ? Dunno what the symbol is for that.
IDE does not recognize it if you don't specify it.
Oh so it's for autocompletion… I see.
There was a problem hiding this comment.
Oh so it's for autocompletion… I see.
Not only. Type should be specified IMO.
Mock are special, because both types are acceptable.
Dunno what the symbol is for that.
I will let it as is for the moment.
soullivaneuh
force-pushed
the
deprecated-form-usage
branch
from
85424d1
to
0b0a03a
Compare
Replaces #587
Changelog