Fix wrong property name on FormContractor #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @var FormFactoryInterface | ||
| */ | ||
| protected $fieldFactory; | ||
|
|
||
| /** | ||
| * @var FormFactoryInterface | ||
| */ | ||
| protected $formFactory; |
There was a problem hiding this comment.
Does it need to be protected ?
There was a problem hiding this comment.
I don't know, but this was done like this for the fake one. We can discuss it later.
|
Please wait the patch release before merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Subject
The other is never used. As a protected one, I keep it for BC.
Because of the deprecation, this should be delivered as a new minor.