fix one to many inline table #791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Jan 12, 2018
| @@ -22,7 +22,8 @@ file that was distributed with this source code. | |||
| {% if nested_field.vars['required'] %} | |||
| class="required" | |||
| {% endif %} | |||
| {% if (nested_field.vars['attr']['hidden'] is defined) and (nested_field.vars['attr']['hidden']) %} | |||
| {% if (((nested_field.vars['attr']['hidden'] is defined) and (nested_field.vars['attr']['hidden'])) | |||
There was a problem hiding this comment.
The extra parens you are adding are unnecessary because of operator precedence I think
There was a problem hiding this comment.
Yes, first is totally unnecessary (habit from PHP). But second makes it more friendly to read.
greg0ire
reviewed
Jan 12, 2018
| @@ -22,7 +22,8 @@ file that was distributed with this source code. | |||
| {% if nested_field.vars['required'] %} | |||
| class="required" | |||
| {% endif %} | |||
| {% if (nested_field.vars['attr']['hidden'] is defined) and (nested_field.vars['attr']['hidden']) %} | |||
| {% if (((nested_field.vars['attr']['hidden'] is defined) and (nested_field.vars['attr']['hidden'])) | |||
| or (nested_field.vars.sonata_admin.field_description and nested_field.vars.sonata_admin.field_description.type == 'Sonata\\AdminBundle\\Form\\Type\\ModelHiddenType')) %} | |||
|
This template is deprecated. If any, this belongs to the admin bundle |
|
Ok, you are right. I didn't see this^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because there is no BC-break.
Closes #790
Changelog
Subject
Changes inside
edit_orm_one_to_many_inline_table.html.twigtemplate.