Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new filter for empty fields #979

Merged
merged 1 commit into from Jul 10, 2020
Merged

Conversation

core23
Copy link
Member

@core23 core23 commented Feb 7, 2020

Subject

This filter allows filtering for (non-)nullable fields.

I am targeting this branch, because this is BC.

Changelog

### Added
-  Add new filter for empty fields

OskarStark
OskarStark previously approved these changes Feb 8, 2020
@core23 core23 force-pushed the empty-filter branch 3 times, most recently from ed6d14b to 5932dfa Compare April 3, 2020 14:01
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

src/Filter/EmptyFieldFilter.php Outdated Show resolved Hide resolved
src/Filter/EmptyFieldFilter.php Outdated Show resolved Hide resolved
src/Filter/EmptyFieldFilter.php Outdated Show resolved Hide resolved
tests/Filter/EmptyFieldFilterTest.php Outdated Show resolved Hide resolved
src/Filter/EmptyFieldFilter.php Outdated Show resolved Hide resolved
src/Filter/EmptyFieldFilter.php Outdated Show resolved Hide resolved
src/Filter/EmptyFieldFilter.php Outdated Show resolved Hide resolved
src/Filter/EmptyFieldFilter.php Outdated Show resolved Hide resolved
@core23 core23 force-pushed the empty-filter branch 3 times, most recently from 7985520 to 04cdb1a Compare July 2, 2020 17:50
@core23
Copy link
Member Author

core23 commented Jul 2, 2020

Thanks for the Feedback @VincentLanglet . This was just some very old code from my private project I want to share.

@core23 core23 marked this pull request as ready for review July 2, 2020 18:11
@core23 core23 requested a review from phansys July 2, 2020 18:11
src/Filter/EmptyFieldFilter.php Outdated Show resolved Hide resolved
phansys
phansys previously approved these changes Jul 2, 2020
@core23 core23 force-pushed the empty-filter branch 2 times, most recently from 0357430 to c19a1f9 Compare July 3, 2020 20:52
src/Filter/EmptyFieldFilter.php Outdated Show resolved Hide resolved
tests/Filter/EmptyFieldFilterTest.php Outdated Show resolved Hide resolved
@core23 core23 requested a review from a team July 9, 2020 20:57
@phansys phansys merged commit b8dafb6 into sonata-project:3.x Jul 10, 2020
@phansys
Copy link
Member

phansys commented Jul 10, 2020

Thank you @core23!

@core23 core23 deleted the empty-filter branch July 10, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants