Make test work with strict comparisons

sonata-project · Sep 14, 2019 · 2ed5f75 · 2ed5f75
1 parent 5521a8e
commit 2ed5f75
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/tests/Unit/Filter/BooleanFilterTest.php b/tests/Unit/Filter/BooleanFilterTest.php
@@ -56,8 +56,8 @@ public function testFilterEmptyArrayDataWithMeaninglessValue(): void
     public function getFilters()
     {
         return [
-            ['eq', BooleanType::TYPE_YES, 1],
-            ['eq', BooleanType::TYPE_NO, 0],
+            ['eq', BooleanType::TYPE_YES, true],
+            ['eq', BooleanType::TYPE_NO, false],
         ];
     }
 

diff --git a/tests/Unit/Filter/DateFilterTest.php b/tests/Unit/Filter/DateFilterTest.php
@@ -77,7 +77,11 @@ public function testFilterSwitch($operatorMethod, $choiceType, $expectedValue =
 
         $this->assertSame('a', $opDynamic->getAlias());
         $this->assertSame('somefield', $opDynamic->getField());
-        $this->assertSame($expectedValue, $opStatic->getValue());
+        $this->assertTrue(
+            $expectedValue instanceof \DateTimeInterface ?
+            $expectedValue->getTimestamp() === $opStatic->getValue()->getTimestamp() :
+            $expectedValue === $opStatic->getValue()
+        );
 
         $this->assertTrue($this->filter->isActive());
     }
@@ -102,7 +106,7 @@ public function testFilterEquals(): void
 
         $this->assertSame('a', $opDynamic->getAlias());
         $this->assertSame('somefield', $opDynamic->getField());
-        $this->assertSame($from, $opStatic->getValue());
+        $this->assertSame($from->getTimestamp(), $opStatic->getValue()->getTimestamp());
 
         // TO
         $opDynamic = $this->qbTester->getNode(
@@ -112,7 +116,7 @@ public function testFilterEquals(): void
 
         $this->assertSame('a', $opDynamic->getAlias());
         $this->assertSame('somefield', $opDynamic->getField());
-        $this->assertSame($to, $opStatic->getValue());
+        $this->assertSame($to->getTimestamp(), $opStatic->getValue()->getTimestamp());
 
         $this->assertTrue($this->filter->isActive());
     }