Merge 4253bf4 into c31b954

.flintci.yml

@@ -2,3 +2,4 @@ services:
   composernormalize: true
   phpcsfixer: true
   yamllint: true
+  xmllint: true

.gitattributes

@@ -1,4 +1,4 @@
 .* export-ignore
 *.md export-ignore
-tests/* export-ignore
-docs/* export-ignore
+tests export-ignore
+docs export-ignore

.github/ISSUE_TEMPLATE/Bug.md

@@ -1,6 +1,7 @@
 ---
 name: 🐞 Bug Report
 about: Something is broken? 🔨
+labels: bug, unconfirmed
 ---
 
 <!--

.github/ISSUE_TEMPLATE/Feature.md

@@ -1,6 +1,7 @@
 ---
 name: 🚀 Feature Request
 about: I have a suggestion (and may want to implement it 🙂)!
+labels: feature
 ---
 
 ## Feature Request

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,4 +1,7 @@
 <!-- THE PR TEMPLATE IS NOT AN OPTION. DO NOT DELETE IT, MAKE SURE YOU READ AND EDIT IT! -->
+## Subject
+
+<!-- Describe your Pull Request content here -->
 
 <!--
     Show us you choose the right branch.
@@ -21,11 +24,13 @@ Closes #{put_issue_number_here}
 <!-- MANDATORY
     Fill the changelog part inside the code block.
     Follow this schema: http://keepachangelog.com/
+    This will end up on https://github.com/sonata-project/SonataDoctrinePhpcrAdminBundle/releases,
+    please keep it short and clear and to the point
 -->
 
 <!-- 
     If you are updating something that doesn't require
-    a release, you can delete whole Changelog section.
+    a release, you can delete the whole Changelog section.
     (eg. update to docs, tests)
 -->
 
@@ -56,7 +61,3 @@ Closes #{put_issue_number_here}
     - [ ] Update the documentation
     - [ ] Add an upgrade note
 -->
-
-## Subject
-
-<!-- Describe your Pull Request content here -->

.gitignore

@@ -4,5 +4,4 @@
 .php_cs.cache
 composer.lock
 phpunit.xml
-tests/Resources/app/cache/
-tests/Resources/app/logs/
+tests/Resources/app/var

.php_cs.dist

@@ -36,6 +36,13 @@ $rules = [
     '@PHP56Migration' => true,
     '@PHP56Migration:risky' => true,
     '@PHPUnit57Migration:risky' => true,
+    '@PHP70Migration' => true,
+    '@PHP70Migration:risky' => true,
+    '@PHPUnit60Migration:risky' => true,
+    '@PHP71Migration' => true,
+    '@PHP71Migration:risky' => true,
+    'compact_nullable_typehint' => true,
+    'void_return' => null,
     // To be tested before insertion:
 //    'strict_comparison' => true,
 //    'strict_param' => true,

.travis.yml

@@ -10,10 +10,9 @@ branches:
 language: php
 
 php:
-  - '5.6'
-  - '7.0'
   - '7.1'
   - '7.2'
+  - '7.3'
   - nightly
 
 sudo: false
@@ -32,36 +31,33 @@ cache:
 env:
   global:
     - PATH="$HOME/.local/bin:$PATH"
-    - SYMFONY_DEPRECATIONS_HELPER=weak_vendors
+    - SYMFONY_DEPRECATIONS_HELPER=weak
     - TARGET=test
     - UPSTREAM_URL=https://github.com/sonata-project/SonataDoctrinePhpcrAdminBundle.git
+    - PHPUNIT_VERSION=7
 
 matrix:
   fast_finish: true
   include:
-    - php: '7.2'
+    - php: '7.3'
       env: TARGET=docs
-    - php: '7.2'
+    - php: '7.3'
       env: TARGET=lint
-    - php: '5.6'
+    - php: '7.1'
       env: COMPOSER_FLAGS="--prefer-lowest"
-    - php: '7.2'
-      env: SYMFONY=2.8.*
-    - php: '7.2'
-      env: SYMFONY=3.3.*
-    - php: '7.2'
+    - php: '7.3'
       env: SYMFONY=3.4.*
-    - php: '7.2'
+    - php: '7.3'
       env: SYMFONY='dev-master as 3.4.x-dev'
-    - php: '7.2'
+    - php: '7.3'
       env: SONATA_ADMIN=3.*
-    - php: '7.2'
+    - php: '7.3'
       env: SONATA_ADMIN='dev-master as 3.x-dev'
-    - php: '7.2'
+    - php: '7.3'
       env: SONATA_BLOCK=3.*
-    - php: '7.2'
+    - php: '7.3'
       env: SONATA_BLOCK='dev-master as 3.x-dev'
-    - php: '7.2'
+    - php: '7.3'
       env: SYMFONY_DEPRECATIONS_HELPER=0
   allow_failures:
     - php: nightly

.travis/before_script_test.sh

@@ -1,3 +1,7 @@
 #!/usr/bin/env bash
 set -ev
 
+if [ -f before_script_test.local.sh ]
+then
+    ./before_script_test.local.sh
+fi

.travis/install_test.sh

@@ -3,12 +3,6 @@ set -ev
 
 mkdir --parents "${HOME}/bin"
 
-# PHPUnit install
-if [ "${TRAVIS_BRANCH}" = 'master' ]; then
-    PHPUNIT_VERSION=7
-else
-    PHPUNIT_VERSION=5.7
-fi
 wget "https://phar.phpunit.de/phpunit-${PHPUNIT_VERSION}.phar" --output-document="${HOME}/bin/phpunit"
 chmod u+x "${HOME}/bin/phpunit"
 

CONTRIBUTING.md

@@ -516,6 +516,24 @@ Thank them for contributing. Encourage them if you feel this is going to be long
 In short, try to make them want to contribute again. If they are stuck, try to provide them with
 code yourself, or ping someone who can help.
 
+## Manual merges
+
+Thanks to dev-kit, stable branches are regularly merged into master branches.
+It is great when it works, but often, there will be git conflicts and a human
+intervention will be needed. Let us assume we are working on a repository where
+the stable branch is 42.x. To do the merge manually, follow these steps:
+1. Fetch the latest commits: `git fetch --all`
+2. Checkout the master branch, and make sure it is up to date:
+   `git checkout -B master origin/master`
+3. Proceed with the merge: `git merge origin/42.x`
+4. Fix the conflicts (if you are doing this, it is because of conflicts,
+   right?) `git mergetool`
+5. Create a merge commit `git commit`
+6. Push the result to your fork: `git push fork 42.x`
+7. Create a pull request from `fork/42.x` to `origin/42.x`
+8. When the PR can be merged, do not merge it. Instead, use
+   `git push origin 42.x`.
+
 ## Releases
 
 ### Limitations and requests

composer.json

@@ -21,7 +21,7 @@
         }
     ],
     "require": {
-        "php": "^5.6 || ^7.0",
+        "php": "^7.1",
         "doctrine/phpcr-bundle": "^1.3 || ^2.0",
         "doctrine/phpcr-odm": "^1.4 || ^2.0",
         "sonata-project/admin-bundle": "^3.30.1",
@@ -30,8 +30,8 @@
         "symfony-cmf/tree-browser-bundle": "^2.0",
         "symfony/config": "^2.8 || ^3.2",
         "symfony/dependency-injection": "^2.8 || ^3.2",
-        "symfony/form": "^2.8 || ^3.2",
-        "symfony/framework-bundle": "^2.8 || ^3.2",
+        "symfony/form": "^2.8.8 || ^3.2",
+        "symfony/framework-bundle": "^2.8.8 || ^3.2",
         "symfony/http-foundation": "^2.8 || ^3.2",
         "symfony/http-kernel": "^2.8 || ^3.2",
         "symfony/options-resolver": "^2.8 || ^3.2",
@@ -43,14 +43,14 @@
     "require-dev": {
         "dantleech/glob-finder": "^1.0",
         "jackalope/jackalope-jackrabbit": "^1.3",
-        "matthiasnoback/symfony-dependency-injection-test": "^1.1",
+        "matthiasnoback/symfony-dependency-injection-test": "^3.1",
         "phpcr/phpcr": "^2.1",
         "phpcr/phpcr-utils": "^1.4.0",
         "sonata-project/core-bundle": "^3.8",
         "symfony-cmf/resource": "^1.0",
         "symfony-cmf/resource-bundle": "^1.0",
-        "symfony-cmf/testing": "2.0.*",
-        "symfony/phpunit-bridge": "^4.0",
+        "symfony-cmf/testing": "^2.1.11",
+        "symfony/phpunit-bridge": "^4.2",
         "symfony/routing": "^2.8 || ^3.2",
         "symfony/security-acl": "^2.8 || ^3.0"
     },

docs/conf.py

@@ -18,6 +18,10 @@
 # documentation root, use os.path.abspath to make it absolute, like shown here.
 #sys.path.insert(0, os.path.abspath('.'))
 
+# adding PhpLexer
+from sphinx.highlighting import lexers
+from pygments.lexers.web import PhpLexer
+
 # -- General configuration -----------------------------------------------------
 
 # If your documentation needs a minimal Sphinx version, state it here.
@@ -40,8 +44,8 @@
 master_doc = 'index'
 
 # General information about the project.
-project = u'Sonata ~ DoctrinePhpcrAdminBundle'
-copyright = u'2010-2015, Thomas Rabaix'
+project = u''
+copyright = u'2010-2019, Thomas Rabaix'
 
 # The version info for the project you're documenting, acts as replacement for
 # |version| and |release|, also used in various other places throughout the
@@ -83,9 +87,18 @@
 # The name of the Pygments (syntax highlighting) style to use.
 pygments_style = 'sphinx'
 
+# This will be used when using the shorthand notation
+highlight_language = 'php'
+
 # A list of ignored prefixes for module index sorting.
 #modindex_common_prefix = []
 
+# -- Settings for symfony doc extension ---------------------------------------------------
+
+# enable highlighting for PHP code not between ``<?php ... ?>`` by default
+lexers['php'] = PhpLexer(startinline=True)
+lexers['php-annotations'] = PhpLexer(startinline=True)
+lexers['php-standalone'] = PhpLexer(startinline=True)
 
 # -- Options for HTML output ---------------------------------------------------
 import sphinx_rtd_theme
@@ -241,3 +254,6 @@
 
 # How to display URL addresses: 'footnote', 'no', or 'inline'.
 #texinfo_show_urls = 'footnote'
+
+# Use PHP syntax highlighting in code examples by default
+highlight_language='php'

phpunit.xml.dist

@@ -8,11 +8,11 @@
          convertWarningsToExceptions="true"
          processIsolation="false"
          stopOnFailure="false"
-         syntaxCheck="false"
          bootstrap="vendor/symfony-cmf/testing/bootstrap/bootstrap.php"
 >
     <php>
         <server name="KERNEL_DIR" value="tests/Resources/app" />
+        <ini name="precision" value="8"/>
     </php>
 
     <testsuites>
@@ -45,8 +45,4 @@
         <listener class="Symfony\Cmf\Component\Testing\Phpunit\DatabaseTestListener" />
     </listeners>
 
-    <php>
-        <ini name="precision" value="8"/>
-    </php>
-
 </phpunit>

src/Admin/Admin.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the Sonata Project package.
  *

src/Admin/FieldDescription.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the Sonata Project package.
  *

src/Block/TreeBlockService.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the Sonata Project package.
  *

src/Builder/DatagridBuilder.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the Sonata Project package.
  *

src/Builder/FormContractor.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the Sonata Project package.
  *

src/Builder/ListBuilder.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the Sonata Project package.
  *

src/Builder/ShowBuilder.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the Sonata Project package.
  *

src/Controller/AutocompleteController.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the Sonata Project package.
  *

src/Controller/TreeController.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the Sonata Project package.
  *

src/Datagrid/Pager.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the Sonata Project package.
  *

src/Datagrid/ProxyQuery.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the Sonata Project package.
  *
@@ -37,7 +39,7 @@ class ProxyQuery implements ProxyQueryInterface
     /**
      * The root path.
      *
-     * @var null|string
+     * @var string|null
      */
     protected $root;
 

src/DependencyInjection/Compiler/AddGuesserCompilerPass.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the Sonata Project package.
  *