Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Travis: Cleanup configuration #362

Merged
merged 1 commit into from
Apr 1, 2016
Merged

Travis: Cleanup configuration #362

merged 1 commit into from
Apr 1, 2016

Conversation

core23
Copy link
Member

@core23 core23 commented Mar 30, 2016

  • moved php-cs-fixer to travis
  • php-cs-fixers runs once under PHP7
  • sphinx-build runs once under PHP7
  • added PHP nightly builds

Refs sonata-project/SonataAdminBundle#3584

@core23
Copy link
Member Author

core23 commented Mar 30, 2016

Some unit tests are failing. The last build is more than 2 months old

@dbu
Copy link
Contributor

dbu commented Apr 1, 2016

i just restarted the master build and its still green, so it smells like something in this PR is breaking things.

- php: 5.6
env: SYMFONY_VERSION=3.0.*
- php: 7.0
env: SYMFONY_VERSION=3.0.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a lot of builds. i would say we want to build every php version once and every symfony version once with a specific php version. no need to build symfony 3 3 times.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a long discussion in the past weeks what we should test in travis... Too many environments shouldn't be any problem ;)

Only symfony 3.0 is build by all supported php versions. After the next major release of Sonata*Bundle the build will be very short.

@dbu
Copy link
Contributor

dbu commented Apr 1, 2016

tough i can't see why that would be. i guess rebasing this branch does not change anything?

@core23
Copy link
Member Author

core23 commented Apr 1, 2016

Rebased this and everything is green @dbu

@dbu dbu merged commit c2febb4 into sonata-project:master Apr 1, 2016
@lsmith77 lsmith77 removed the wip/poc label Apr 1, 2016
@dbu
Copy link
Contributor

dbu commented Apr 1, 2016

\o/

@core23 core23 deleted the travis branch April 1, 2016 13:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants