Use render() function instead of block #375
Conversation
|
@wouterj Is that compatible with SF 2.3? |
| @@ -17,7 +17,7 @@ file that was distributed with this source code. | |||
| <h3 class="box-title">{{ 'content_tree' | trans({}, 'SonataDoctrinePHPCRAdmin') }}</h3> | |||
| </div> | |||
| <div class="box-body"> | |||
| {% render controller('sonata.admin.doctrine_phpcr.tree_controller:treeAction', { 'root': settings.id, 'selected': settings.selected }) %} | |||
| {{ render(controller('sonata.admin.doctrine_phpcr.tree_controller:treeAction', { 'root': settings.id, 'selected': settings.selected })) }} | |||
There was a problem hiding this comment.
Would you consider also linebreaking this in a separate commit while you're at it ?
There was a problem hiding this comment.
Thanks a lot for doing that, another step towards sane code.
|
Tests fail because this bundle's requirements no longer support Symfony 2.3. What about dropping it? (Symfony 2.3 has reached end of maintainance some days ago) |
|
Or maybe find a way to make it BC? @soullivaneuh to the rescue ? BTW, if this was planned to be BC, should it have been based on master? Why is master the default branch for this bundle ? It not very clear what the status is even after reading sonata-project/SonataAdminBundle#3731 |
|
@greg0ire it's about the Resource(Rest)Bundle dependency. This bundle's 1.0 version is going to be included in the CMF 2 release, which targets Symfony 2.8+ and PHP 5.5+. As this bundle depends on it, this bundle's 2.0 version (master is 2.0 dev) will also only support 2.8+ and PHP 5.5+. |
|
Btw, this is not an issue caused by this PR, master is broken by default. Can we please discuss this in another pull request and merge this one? |
|
The build is green for master : https://travis-ci.org/sonata-project/SonataDoctrinePhpcrAdminBundle/builds/129346090 , so I'm very reluctant to merge this. It would mean we would have to check every job of every build to make sure the only tests that are failing are the one that fail in this PR. Besides, I think dropping 2.3 support can be done quite quickly. |
|
Oh sorry I misread your post, master should indeed be broken. |
|
Well since there is no current way to make it green, I guess I'll just merge. |
|
@soullivaneuh , in this file, does the |
|
Thanks for the merge! |
Thanks for the contribution ;) |
First of all, dev-kit does not generate composer.json. It distpatch a lint. This bundle is one of the projects I still have to integrate. And yes, all projects with no configuration ( |
Another step towards Symfony 3 compatibility.