This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
Drop old versions of php/sf #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The old PR had some sync problems #499 (comment) |
jordisala1991
approved these changes
Oct 14, 2017
ElectricMaxxx
suggested changes
Oct 16, 2017
| @@ -16,15 +16,15 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": "^5.6 || ^7.0", | |||
| "php": "^7.1", | |||
There was a problem hiding this comment.
Not sure if we can drop that on next minor release.
There was a problem hiding this comment.
We can, and did on all other packages.
| "doctrine/phpcr-bundle": "^1.1", | ||
| "doctrine/phpcr-odm": "^1.3 || ^2.0", | ||
| "sonata-project/admin-bundle": "^3.21.0", | ||
| "sonata-project/block-bundle": "^3.0", | ||
| "symfony-cmf/resource-rest-bundle": "^1.0", | ||
| "symfony-cmf/tree-browser-bundle": "^2.0", | ||
| "symfony/framework-bundle": "^2.8 || ^3.0", | ||
| "symfony/property-access": "^2.8 || ^3.0" | ||
| "symfony/framework-bundle": "^2.8 || ^3.2", |
There was a problem hiding this comment.
Why keeping 2.8 then, LTS?
dbu
approved these changes
Oct 17, 2017
|
@ElectricMaxxx please review again |
ElectricMaxxx
approved these changes
Oct 17, 2017
|
Thanks @core23 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because this is BC.
Changelog