Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

DevKit updates for 2.x branch #556

Merged
merged 6 commits into from
Nov 12, 2019
Merged

DevKit updates for 2.x branch #556

merged 6 commits into from
Nov 12, 2019

Conversation

SonataCI
Copy link
Collaborator

No description provided.

OskarStark
OskarStark reviewed Sep 15, 2019
View reviewed changes
Copy link
Member

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greg0ire can we make this configurable via dev kit or fix the remaining Deprecations? 🤔

core23
core23 previously approved these changes Sep 15, 2019
View reviewed changes
greg0ire
greg0ire suggested changes Sep 15, 2019
View reviewed changes
Copy link
Contributor

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's prevent the merge

@greg0ire
Copy link
Contributor

Here is the list of deprecations that are wrongly detected as self deprecations:

    6x: The "templating.locator" service is deprecated since Symfony 4.3 and will be removed in 5.0.
        1x in ContentAdminTest::testContentList from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testContentWithChildEdit from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testContentWithChildrenEdit from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testContentCreate from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testShowContent from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in TreeBrowserTest::testTreeOnDashboardLoadsWithNoErrors from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Dashboard
      6x: The "templating.name_parser" service is deprecated since Symfony 4.3 and will be removed in 5.0.
        1x in ContentAdminTest::testContentList from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testContentWithChildEdit from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testContentWithChildrenEdit from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testContentCreate from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testShowContent from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in TreeBrowserTest::testTreeOnDashboardLoadsWithNoErrors from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Dashboard
      6x: The "sonata.core.model.adapter.chain" service is deprecated in favor of service "sonata.doctrine.model.adapter.chain" since 3.12.0 and will be removed in 4.0.
        1x in ContentAdminTest::testContentList from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testContentWithChildEdit from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testContentWithChildrenEdit from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testContentCreate from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testShowContent from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in TreeBrowserTest::testTreeOnDashboardLoadsWithNoErrors from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Dashboard
      6x: The "sonata.core.model.adapter.doctrine_orm" service is deprecated in favor of service "sonata.doctrine.adapter.doctrine_orm" since 3.12.0 and will be removed in 4.0.
        1x in ContentAdminTest::testContentList from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testContentWithChildEdit from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testContentWithChildrenEdit from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testContentCreate from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testShowContent from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in TreeBrowserTest::testTreeOnDashboardLoadsWithNoErrors from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Dashboard
      6x: The "sonata.core.model.adapter.doctrine_phpcr" service is deprecated in favor of service "sonata.doctrine.adapter.doctrine_phpcr" since 3.12.0 and will be removed in 4.0.
        1x in ContentAdminTest::testContentList from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testContentWithChildEdit from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testContentWithChildrenEdit from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testContentCreate from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in ContentAdminTest::testShowContent from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Admin
        1x in TreeBrowserTest::testTreeOnDashboardLoadsWithNoErrors from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Dashboard
      1x: The "sonata.templating" service is deprecated since sonata-project/block-bundle 3.17 and will be removed in version 4.0.
        1x in TreeBrowserTest::testTreeOnDashboardLoadsWithNoErrors from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Dashboard
      1x: The "sonata.templating.name_parser" service is deprecated since sonata-project/block-bundle 3.17 and will be removed in version 4.0.
        1x in TreeBrowserTest::testTreeOnDashboardLoadsWithNoErrors from Sonata\DoctrinePHPCRAdminBundle\Tests\WebTest\Dashboard

I will try to have a look at them soon.

@greg0ire
Copy link
Contributor

I think most of these deprecations come from the block bundle.

core23
core23 previously approved these changes Nov 12, 2019
View reviewed changes
@greg0ire
Move cache and logs outside the kernel directory
abdf80a 
Hopefully this will help the bridge detect some deprecations as not self
deprecations.
@greg0ire
Copy link
Contributor

I think this is going to be the one true build 🤞 no more need to fiddle with the deprecation settings @OskarStark @core23

@greg0ire greg0ire merged commit 45e08ce into 2.x Nov 12, 2019
@greg0ire greg0ire deleted the 2.x-dev-kit branch November 12, 2019 23:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@OskarStark OskarStark OskarStark left review comments

@greg0ire greg0ire greg0ire approved these changes

@core23 core23 core23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SonataCI @greg0ire @OskarStark @core23 @soullivaneuh