Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Fix Media compatibilty #85

Merged
merged 2 commits into from Mar 2, 2013
Merged

Fix Media compatibilty #85

merged 2 commits into from Mar 2, 2013

Conversation

nicolas-bastien
Copy link
Contributor

As admin dev master moved to 2.2 we need to stay in 2.1 if we want to
work with SonataMediaBundle
which depends on notification 2.1 
which depends on admin 2.1

As admin dev master moved to 2.2 we need to stay in 2.1 if we want to 
work with SonataMediaBundle 
which depends on notification 2.1 
which depends on admin 2.1
@dbu
Copy link
Contributor

dbu commented Mar 2, 2013

oh what a mess. the dependency is definitely wrong with dev-master. can we depend on >=2.1 <=2.3-dev? so, is there a reason we are specifically incompatible with sonata admin 2.2?

@nicolas-bastien
Copy link
Contributor Author

Hi, the problem is really in sonatamedia.

Sonata media depends on sonata notification 2.1 and sonata admin 2.2 and notification depends on admin 2.1.

But if phpcradmin is fix on dev-master we can't use it with admin 2.1 so I think it's better to allow 2.1 and 2.2

What do you think ?

dbu added a commit that referenced this pull request Mar 2, 2013
@dbu dbu merged commit f2f76af into sonata-project:master Mar 2, 2013
@dbu
Copy link
Contributor

dbu commented Mar 2, 2013

thanks. better than dev-master for sure.

we will need to find out if this is now really true, or if there are real BC breaks between the sonata media between 2.1 and 2.2. then we would need to either fix, them, work around them or start branching. or maybe just drop symfony 2.1 support. branching is really bad, as it explodes the maintanance efforts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants