Prefix every filter with sonata_ to avoid conflict

[VincentLanglet]

Subject

I am targeting this branch, because minor.

This might be annoying to have a sonata_ prefix, but I don't see an other way to be sure to avoid a conflict with either twigIntl or another library.

Closes #299.

Changelog

### Added
-`sonata_format_date` filter
-`sonata_format_time` filter
-`sonata_format_datetime` filter
-`sonata_number_format_*` filters
-`sonata_country` filter
-`sonata_locale` filter
-`sonata_language` filter

### Deprecated
-`format_date` filter
-`format_time` filter
-`format_datetime` filter
-`number_format_*` filters
-`country` filter
-`locale` filter
-`language` filter

[jordisala1991]

It would be nice to prefix our functions, but also IMO we should deprecate the old methods. To do so, maybe it is easier if you introduce twigRuntime for the new functions, so you dont rely on same implementation, and can add a deprecation message.

[jordisala1991]

Those should use the new runtime directly

[VincentLanglet]

Done

[franmomu]

IMO these messages should encourage the user to use the new sonata_* filters instead of runtime class.

[VincentLanglet]

Done

[franmomu]

To avoid conflict for users installing both twig/intl-extra and this bundle we can maybe to add a config parameter to not load the current filters.

[VincentLanglet]

To avoid conflict for users installing both twig/intl-extra and this bundle we can maybe to add a config parameter to not load the current filters.

SonataAdmin is using the format_datetime template of SonataIntl when this bundle is used ; which used the sonata_format_datetime twig method. Also people might want to use sometimes one and sometimes another method.

[franmomu]

To avoid conflict for users installing both twig/intl-extra and this bundle we can maybe to add a config parameter to not load the current filters.

SonataAdmin is using the format_datetime template of SonataIntl when this bundle is used ; which used the sonata_format_datetime twig method. Also people might want to use sometimes one and sometimes another method.

Not sure if I understand, but what I meant is that this PR provides alternative sonata_* filters which is fine, but if someone who has twig/intl-extra and this bundle installed wants to use let's say format_date from twig/intl-extra they cannot if this bundle registers filters after twig/intl-extra. Like sonata-project/SonataNewsBundle#591

[VincentLanglet]

Not sure if I understand, but what I meant is that this PR provides alternative sonata_* filters which is fine, but if someone who has twig/intl-extra and this bundle installed wants to use let's say format_date from twig/intl-extra they cannot if this bundle registers filters after twig/intl-extra. Like sonata-project/SonataNewsBundle#591

Currently, if you use both sonata-intl and twig-intl, there is an issue even if you are using none of these methods : If the twig intl is declared after the sonata intl one, the datetime field from sonataAdmin is crashing.
By adding the prefix, I fix the display of the datetime field for SonataAdmin users.

If the twig intl is declared after the sonata intl one, with this PR it will be possible for the user to have no issue

• format_date will be the twig one
• sonata_format_date won't conflict.

If the sonata intl is declared after the twig intl one, indeed there will still be an issue so far. It will be fixed in next major.

[jordisala1991]

What bundles of Sonata make use of this functions? (Only the non deprecated / abandoned)

[VincentLanglet]

What bundles of Sonata make use of this functions? (Only the non deprecated / abandoned)

Only deprecated/abandoned one are using them.

Can we merge this PR, at least as a first step ?

[jordisala1991]

if none of the Sonata bundles are using those features. We could even study if this bundle is really needed or we can deprecate it.

But that is another topic, IMO you can merge, yes

[VincentLanglet]

if none of the Sonata bundles are using those features. We could even study if this bundle is really needed or we can deprecate it.

None are using directly those methods. But there are templates used by SonataAdmin (which is the issue I try to solve).

[core23]

The last release is broken, because DateTimeRuntime is not registered as a service

[VincentLanglet]

Can you do the Pr to fix the three runtime ? (Or i'll do later) I m currently on phone ?

[jordisala1991]

Would. be nice to have a minimal test setup that catches those basic errors

[VincentLanglet]

Found time for #514