Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevKit updates for 3.x branch #598

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

phansys
Copy link
Member

@phansys phansys commented Dec 7, 2023

Subject

I am targeting this branch, because these changes respect BC.

Closes #596.

Changelog

### Fixed
- Passing an empty string as argument 1 to `\DateTimeZone` at `DateTimeFormatter::getDatetime()`

@phansys phansys marked this pull request as ready for review December 7, 2023 09:46
Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird PR title

@phansys
Copy link
Member Author

phansys commented Dec 7, 2023

I stole the title from the DevKit PR as the additional changes here are only intended to fix what prevents that PR to be merged.
Feel free to update if you think it is required.

@phansys phansys merged commit 98dfdd8 into sonata-project:3.x Dec 7, 2023
18 checks passed
@phansys phansys deleted the devkit-3.x branch December 7, 2023 09:54
@phansys phansys added the patch label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants