Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix liip cdn url generating (don't use cdn prefix twice) #550

Closed

Conversation

AlexKovalevych
Copy link

Fix which prevents liip service from using cdn prefix twice (second time its used here https://github.com/sonata-project/SonataMediaBundle/blob/master/Provider/ImageProvider.php#L153 during image url creating)

@core23
Copy link
Member

core23 commented Apr 16, 2016

Are you still working on this? Please squash and rebase or close this PR @AlexKovalevych

@soullivaneuh
Copy link
Member

According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning.

If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch.

So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one).

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants