Add an icon to admin menu. #1142
Conversation
| @@ -1,6 +1,9 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | |||
| <parameters> | |||
| <!-- COMMON --> | |||
| <parameter key="sonata.media.admin.groupname">sonata_media</parameter> | |||
There was a problem hiding this comment.
What does this have to do with the issue at hand exactly?
There was a problem hiding this comment.
Nothing. Should I remove it? Or create another commit if it has any kind of interest for you?
There was a problem hiding this comment.
I don't know what interest it has exactly, but if you find one, then make sure it appears in your commit message. As a rule of thumb, try to have commit messages that look like this :
What you are doing
<blank line>
Why you are doing it
More information about commit messages can be found in the CONTRIBUTING.md
Anyway, nice first PR, it is quite clean (cleaner than the average PR IMO).
|
how do we set the icon for the other bundles? is it done in this way? |
|
@OskarStark Yes. It's almost a copy/paste from SonataUserBundle. It is also the reason why I introduced the parameter |
Then your commit message should read |
|
Thank you for theses advices @greg0ire. |
|
You're welcome. The way I see it, the easiest way for you to do that would be :
There are more complex solutions with |
There was no icon on menu.
Let's be consistent with the user bundle.
|
Done :). |
|
Is this PR waiting for something or we can merge it? |
|
@sonata-project/contributors please review |
|
Thanks @jlamur ! |
This is my first PR, I'm sorry if I do something in the wrong way !
I am targetting this branch, because it's a minor change that does not break BC.
Changelog
Subject
There was no image in the admin menu. So I added one :)