Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Swagger definition in order to be compatible with string identifier #1800

Merged
merged 3 commits into from
Sep 1, 2020
Merged

Update Swagger definition in order to be compatible with string identifier #1800

merged 3 commits into from
Sep 1, 2020

Conversation

wbloszyk
Copy link
Member

@wbloszyk wbloszyk commented Sep 1, 2020 •
edited
Loading

Subject

Update OpenAPI (Swagger) definition in order to be compatible with string identifiers (like UUIDs).

These changes are consistent with the API narrowing made at sonata-project/admin-bundle (see AdminInterface::id()).

I am targeting this branch, because these changes respect BC.

Part of sonata-project/dev-kit#778

Based on: sonata-project/SonataUserBundle#1198

Changelog

### Removed
- Removed requirements that were only allowing integers for model identifiers at Open API definitions.
### Fixed
- Fixed support for string model identifiers at Open API definitions.

@wbloszyk wbloszyk mentioned this pull request Sep 1, 2020
Closed
43 tasks
@wbloszyk wbloszyk requested a review from a team September 1, 2020 09:59
VincentLanglet
VincentLanglet previously approved these changes Sep 1, 2020
View reviewed changes
@VincentLanglet
Copy link
Member

Lint is failing

@wbloszyk wbloszyk requested review from VincentLanglet and a team September 1, 2020 15:51
VincentLanglet
VincentLanglet approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to squash your commit

@wbloszyk wbloszyk changed the title Update Swagger definition in order to be compatible with string ident… Update Swagger definition in order to be compatible with string identifier Sep 1, 2020
@wbloszyk wbloszyk merged commit 41c375b into sonata-project:3.x Sep 1, 2020
@wbloszyk wbloszyk deleted the support_string_identifier branch September 1, 2020 16:03
@greg0ire greg0ire added the minor label Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wbloszyk @VincentLanglet @greg0ire