-
-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getting values returned by CloudFrontClient
methods when using "aws/aws-sdk-php:^3.0"
#1815
Conversation
ff6e0bd
to
4b94f49
Compare
CloudFrontClient
methods when using …CloudFrontClient
methods when using "aws/aws-sdk-php:^3.0"
7c4ec1b
to
6d5a134
Compare
1eb676b
to
eb3d91c
Compare
eaa656e
to
6273ca6
Compare
What is wrong, and how did you fix that? |
I just extended the PR description in order to explain this. Please, let me know if you think more context is required. |
For anyone reading this, this PR introduces a new client for v3, and uses it in DI based on the existence of a class that exists in only one version of the package. |
8fa726c
to
5ea6955
Compare
Based on this, can we add a test for this DI change? |
81fabdf
to
20215dc
Compare
The tests about the DI behavior were added. |
…"aws/aws-sdk-php:^3.0"
Thanks |
Subject
Fix getting values returned by
CloudFrontClient
methods when using "aws/aws-sdk-php:^3.0".The method
CloudFrontClient::getInvalidation()
from SDK v2 returns the following array structure:while the SDK v3 returns the following:
the same occurs with the method
CloudFrontClient::createInvalidation()
, but we are currently trying to deal with the structure returned by the SDK v3 without being aware of this difference.I am targeting this branch, because these changes respect BC.
Follow up of #1814.
Changelog