Backport ImageProviderInterface from 4.x #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| private $imageProvider; | ||
|
|
||
| public function __construct(ImagineInterface $imagineAdapter, ImageProvider $imageProvider) | ||
| public function __construct(ImagineInterface $imagineAdapter, ImageProviderInterface $imageProvider) |
There was a problem hiding this comment.
Not sure but this change looks like BC break to me.
There was a problem hiding this comment.
I can only think of one situation, namely when someone extends the validator and its constructor.
There was a problem hiding this comment.
Why wouldn't it be BC @jordisala1991 ?
There was a problem hiding this comment.
I could also remove the explicit parameter type and check it at runtime.
There was a problem hiding this comment.
If it is BC, fine by me :)
VincentLanglet
approved these changes
Feb 11, 2022
core23
approved these changes
Feb 12, 2022
|
If it's okay for you @jordisala1991 we'll merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am preparing to migrate to Symfony 5 and all new Sonata bundle, including Media Bundle 4. One issue is that I have a class that inherits from
ImageProvider. This is no longer possible in 4.0, where a new interfaceImageProviderInterfaceis introduced. It would be convenient if I could migrate my implementation to this new interface before migrating every Sonata/Symfony package.I am targeting this branch, because it backports a feature from 4.0.
Changelog