Skip to content
This repository has been archived by the owner on Jul 28, 2022. It is now read-only.

ADD yaml format to the service container configuration. #137

Merged
merged 1 commit into from Aug 7, 2015

Conversation

chigix
Copy link
Contributor

@chigix chigix commented May 20, 2015

Signed-off-by: Richard Lea chigix@zoho.com

@@ -113,6 +113,15 @@ message is receive or created.
</services>
</container>

.. code-block:: yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soullivaneuh
Copy link
Member

ping @chigix

@chigix
Copy link
Contributor Author

chigix commented Aug 4, 2015

Sorry for response so late, I've push an extra commit with the list format and the change for the service argument.

However, I've test there's no effect no matter with the quotation marks in the previous commit. In addition, I saw the official document from symfony also write quotation marks in the service container section.

@soullivaneuh
Copy link
Member

Could you please squash your commit and rebase your PR to make Travis green?

Thanks.

@rande
Copy link
Member

rande commented Aug 6, 2015

ok to test

1 similar comment
@rande
Copy link
Member

rande commented Aug 6, 2015

ok to test

FIX list format for the configuration.
@rande
Copy link
Member

rande commented Aug 7, 2015

ok to test

soullivaneuh added a commit that referenced this pull request Aug 7, 2015
ADD yaml format to the service container configuration.
@soullivaneuh soullivaneuh merged commit 60a34d9 into sonata-project:master Aug 7, 2015
@soullivaneuh
Copy link
Member

Thank you @chigix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants