Skip to content
This repository has been archived by the owner on Jul 28, 2022. It is now read-only.

Add prefetch count configuration in AMQPBackend #257

Merged
merged 8 commits into from
Sep 12, 2017
Merged

Add prefetch count configuration in AMQPBackend #257

merged 8 commits into from
Sep 12, 2017

Conversation

shiroko
Copy link
Contributor

@shiroko shiroko commented Sep 12, 2017

I am targetting this branch, because this change has no influence on current configurations/features,
only add the new feature.

Closes #232

Changelog

### Added
- Added prefetch count configuration in AMQPBackend

Subject

This enables to configure "prefetch_count" for the "Fair dispatch" in RabbitMQ.
reference: https://www.rabbitmq.com/tutorials/tutorial-two-php.html

@greg0ire
Copy link
Contributor

""configration" => "configuration"

@greg0ire greg0ire added the minor label Sep 12, 2017
@@ -63,6 +63,11 @@ class AMQPBackend implements BackendInterface
protected $ttl;

/**
* @var null|int
*/
protected $prefetchCount;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per our new policy, please make this private, although everything else is protected.

@shiroko shiroko changed the title Add prefetch count configration in AMQPBackend Add prefetch count configuration in AMQPBackend Sep 12, 2017
@greg0ire
Copy link
Contributor

Please fix StyleCI

@greg0ire
Copy link
Contributor

And please squash your commits together

@greg0ire greg0ire merged commit cebab90 into sonata-project:3.x Sep 12, 2017
@greg0ire
Copy link
Contributor

greg0ire commented Sep 12, 2017

I squashed your commits for you, thanks a lot for your contribution!

@shiroko
Copy link
Contributor Author

shiroko commented Sep 12, 2017

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control RabbitMQ prefetch settings from the config
4 participants