This repository has been archived by the owner on Jul 28, 2022. It is now read-only.
WIP: Symfony 4 compatibility #284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Nov 18, 2017
.travis.yml
Outdated
| @@ -48,6 +48,8 @@ matrix: | |||
| env: SYMFONY=3.3.* | |||
| - php: '7.1' | |||
| env: SYMFONY='dev-master as 3.3' | |||
| - php: 7.1 | |||
| env: DEPENDENCIES=beta | |||
There was a problem hiding this comment.
We manage this file through dev-kit, you aren't supposed to touch this.
There was a problem hiding this comment.
I saw that in the note in this file. @dbu suggested it would be okay to edit this to start off with, to see what breaks, before finally updating it via the dev-kit.
There was a problem hiding this comment.
No need to, look at the Travis jobs, there is one for sf 4 (dev-master as 3.3)
|
I think we shouldn't merge until we know we are compatible. |
core23
suggested changes
Nov 19, 2017
|
Could you please rebase your PR and fix merge conflicts? |
|
fixed in #288 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because {reason}.
Closes #{put_issue_number_here}
Changelog
To do
Subject