using each() is deprecated since PHP 7.2

[OskarStark]

I am targeting this branch, because its BC.

Closes #306

Changelog

### Fixed
- `each()` is deprecated since PHP 7.2

[jordisala1991]

This line is probably unnecesary too

[jordisala1991]

Maybe we should clear this variable after the foreach? To avoid changing behavior

[OskarStark]

@jordisala1991 looks like the each and the foreach does not result in the same behavior :(

[jordisala1991]

why not?

[jordisala1991]

You cant unset like this in a foreach, you should move this line outside the foreach in the form:

$this->messages = [];

[OskarStark]

You cant unset like this in a foreach

why not? oO

[jordisala1991]

Because you are removing elements on the foreach and php no longer knows what element is next.

On the old code it was doing a each until there are no elements on the array. That's why it was working before

[jordisala1991]

Other option would be doing a while with "there are elements on the array" condition, but IMO a foreach is cleaner

[OskarStark]

still failing :(

[jordisala1991]

Can you try something like this:

while(!empty($this->messages)) {
    $message = array_shift($this->messages);

    $this->handle(...);
}

and you dont need to clear the array anymore

[OskarStark]

Could you provide a PR against mine?

[jordisala1991]

@OskarStark OskarStark#1 there you go

[OskarStark]

Thank you, currently need a lot of time for my son 😉

[kunicmarko20]

could you fix flintCI if you have time

[OskarStark]

did it via the editor on github.com ;-)

[jordisala1991]

Please review @sonata-project/contributors

[greg0ire]

Thanks @OskarStark !