This repository has been archived by the owner on Jul 28, 2022. It is now read-only.
Update stats for BackendHealthCheck in case of doctrine backend is used #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine backend is used
| @@ -97,7 +97,7 @@ public function handle(MessageInterface $message, EventDispatcherInterface $disp | |||
| */ | |||
| public function getStatus() | |||
| { | |||
| return new Success('Channel is running (RabbitMQ) and consumers for all queues available.'); | |||
| return new Success('Channel is running (Database) and consumers for all queues available.'); | |||
There was a problem hiding this comment.
what if someone is testing this message?
There was a problem hiding this comment.
It will break indeed, but it was a wrong one
There was a problem hiding this comment.
what do others think? cc @sonata-project/contributors
There was a problem hiding this comment.
If it was wrong, Imo lets change it
There was a problem hiding this comment.
good enough for me, let's merge it then.
There was a problem hiding this comment.
@kunicmarko20 everything is a BC-break, see my favorite xkcd ;)
mremi
approved these changes
Apr 25, 2018
kunicmarko20
approved these changes
Apr 25, 2018
jordisala1991
approved these changes
Apr 25, 2018
|
Thanks @qsomazzi ! |
|
@sonata-project/contributors thanks ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Subject
The goal of this PR is to fix the way data are manipulated in the case of doctrine backend is used. An SQL query fetch the stats but it raise an error.
Before
In the foreach
$data = '-2'After
In the while
$data = ['state' => -2, 'cnt' => 3]