This repository has been archived by the owner on Jul 28, 2022. It is now read-only.
Bump to SF 4.4 & PHPUnit version 8 #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core23
previously approved these changes
Jan 28, 2020
mazsudo
force-pushed
the
bump-sf-dependency-to-4-4-phpunit-8
branch
from
a94fa39
to
56b3078
Compare
greg0ire
approved these changes
Jan 28, 2020
core23
suggested changes
Jan 28, 2020
|
|
||
| interface MessageManagerInterface extends ManagerInterface, PageableManagerInterface | ||
| interface MessageManagerInterface extends ManagerInterface, PageableInterface |
There was a problem hiding this comment.
It is supposed to be, both names are aliases.
core23
approved these changes
Jan 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this does not contain BC break
Changelog
### Changed Bump SF to 4.4 and PHPUnit to 8 in CI