Prevent to go to createByPage methode on Page deletion (#1721)

Co-authored-by: geraud <gbourdin@partitech.com>
sonata-project · Nov 19, 2023 · 1ba9484 · 1ba9484
1 parent f00641b
commit 1ba9484
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/Admin/Extension/CreateSnapshotAdminExtension.php b/src/Admin/Extension/CreateSnapshotAdminExtension.php
@@ -40,6 +40,10 @@ public function postPersist(AdminInterface $admin, object $object): void
 
     public function postRemove(AdminInterface $admin, object $object): void
     {
+        if ($object instanceof PageInterface) {
+            return;
+        }
+
         $this->createByPage($object);
     }
 

diff --git a/tests/Admin/Extension/CreateSnapshotAdminExtensionTest.php b/tests/Admin/Extension/CreateSnapshotAdminExtensionTest.php
@@ -88,6 +88,18 @@ public function testPostRemoveOnBlock(): void
         $extension->postRemove($admin, $block);
     }
 
+    public function testPostRemoveOnPage(): void
+    {
+        $page = $this->createMock(PageInterface::class);
+        $admin = $this->createStub(AdminInterface::class);
+        $createSnapshotByPage = $this->createMock(CreateSnapshotByPageInterface::class);
+
+        $createSnapshotByPage->expects(static::never())->method('createByPage');
+
+        $extension = new CreateSnapshotAdminExtension($createSnapshotByPage);
+        $extension->postRemove($admin, $page);
+    }
+
     public function testCreateSnapshotByPage(): void
     {
         $admin = $this->createMock(AdminInterface::class);