Merge 77a1251 into c38bbdb

.github/workflows/lint.yaml

@@ -0,0 +1,14 @@
+on: [push, pull_request]
+name: Lint
+jobs:
+    doctor-rst:
+        name: DOCtor-RST
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@master
+            - name: DOCtor-RST
+              uses: docker://oskarstark/doctor-rst
+              with:
+                  args: --short
+              env:
+                  DOCS_DIR: 'docs/'

.github/workflows/stale.yml

@@ -18,12 +18,12 @@ jobs:
           days-before-stale: 180
           repo-token: "${{ secrets.GITHUB_TOKEN }}"
           exempt-issue-label: "keep"
-          stale-issue-label: "pending author"
+          stale-issue-label: "stale"
           stale-issue-message: >
             This issue has been automatically marked as stale because it has not had
             recent activity. It will be closed if no further activity occurs. Thank you
             for your contributions.
-          stale-pr-label: "pending author"
+          stale-pr-label: "stale"
           stale-pr-message: >
             This PR has been automatically marked as stale because it has not had
             recent activity. It will be closed if no further activity occurs. Thank you

docs/.doctor-rst.yaml

@@ -0,0 +1,32 @@
+rules:
+    blank_line_after_directive: ~
+    short_array_syntax: ~
+    typo: ~
+    replacement: ~
+    composer_dev_option_at_the_end: ~
+    yarn_dev_option_at_the_end: ~
+    versionadded_directive_should_have_version: ~
+    no_composer_req: ~
+    no_php_open_tag_in_code_block_php_directive: ~
+    blank_line_after_filepath_in_code_block: ~
+    no_php_prefix_before_bin_console: ~
+    use_deprecated_directive_instead_of_versionadded: ~
+    no_space_before_self_xml_closing_tag: ~
+    no_explicit_use_of_code_block_php: ~
+    ensure_order_of_code_blocks_in_configuration_block: ~
+    american_english: ~
+    valid_use_statements: ~
+    yaml_instead_of_yml_suffix: ~
+    extend_abstract_admin: ~
+    final_admin_class: ~
+    final_admin_extension_classes: ~
+    no_admin_yaml: ~
+    no_bash_prompt: ~
+    no_composer_phar: ~
+    no_inheritdoc: ~
+
+    # can be enabled when no Symfony 3.4 support anymore
+    #no_app_bundle: ~
+    #no_config_yaml: ~
+    #kernel_instead_of_app_kernel: ~
+    #no_app_console: ~

docs/reference/page_services.rst

@@ -17,9 +17,7 @@ return a Response object. At this stage, the page service works a little bit lik
 For example, a simple implementation of a page service is to render the page. Normally, you could simply inject the
 templating engine and use it to render a Response object, just as you would do in a standard Controller. However, pages
 can be configured to use a particular template. Therefore, to render a page, you need to retrieve the page's configured
-template. This can be easily achieved by using the template manager service.
-
-.. code-block:: php
+template. This can be easily achieved by using the template manager service::
 
     // src/App/Service/CustomPageService.php
 
@@ -59,7 +57,7 @@ it as being a page service:
 
     <service id="app.custom_page_service" class="App\Service\CustomPageService">
         <argument>Custom page service</argument>
-        <argument type="service" id="sonata.page.template_manager" />
+        <argument type="service" id="sonata.page.template_manager"/>
         <tag name="sonata.page"/>
     </service>