-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use doctrine/bundle 2 #1099
Merged
Merged
Use doctrine/bundle 2 #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Dec 29, 2019
core23
requested changes
Jan 9, 2020
core23
requested changes
Jan 9, 2020
core23
requested changes
Jan 9, 2020
phansys
requested changes
Jan 9, 2020
Co-Authored-By: Javier Spagnoletti <phansys@gmail.com>
phansys
approved these changes
Jan 9, 2020
franmomu
approved these changes
Jan 9, 2020
core23
approved these changes
Jan 9, 2020
Thanks @Lo-X |
Thank you guys, I learned a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use doctrine/doctrine-bundle 2.x
The recent update of doctrine/doctrine-bundle removed RegistryInterface : https://github.com/doctrine/DoctrineBundle/blob/master/UPGRADE-2.0.md
It was breaking Sonata PageBundle and @greg0ire had to force this bundle compatibility to doctrine/doctrine-bundle 1
This pull request allow the usage of doctrine/doctrine-bundle 2.x.
I am targeting this branch, because even if it changes the signature of two classes' constructors, it also forces doctrine/doctrine-bundle to ^2.0.
Also, the linked issue of symfony/dependency-injection (cdd30d7) doesn't seem to be an issue with this changeerrata: it still seems to be an issue as the tests don't pass, even if I have no visible trouble in my application. I reverted this change.Closes #1094
Changelog