Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make page names more readable when using generator #1127

Merged
merged 1 commit into from Mar 15, 2020

Conversation

core23
Copy link
Member

@core23 core23 commented Mar 14, 2020

Subject

When calling sonata:page:update-core-route, generated page names will not use the route name as default anymore. A meaningful page title will guessed by replacing the underscore with words.

E.g. the generated page for the route sonata_news_view will get Sonata News View as default page name.

The name is only displayed on the admin backend and it will only affect newly generated pages, so this is BC.

I am targeting this branch, because this is BC.

Changelog

### Changed
- Removed underscores in page names when calling `sonata:page:update-core-route`

@core23 core23 added the feature label Mar 14, 2020
@core23 core23 requested a review from a team March 14, 2020 15:12
@core23 core23 requested review from OskarStark and a team March 15, 2020 07:37
@greg0ire greg0ire merged commit 0edbfa9 into sonata-project:3.x Mar 15, 2020
@greg0ire
Copy link
Contributor

Thanks @core23 !

@core23 core23 deleted the page-name branch March 15, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants