Fix: Ignore subrequests metadata only in SiteSelector #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Site selector should not ignore Subrequests, but only metadata override. If whole site use "host_with_path" or "host_with_path_by_locale", subrequests are rejected by router. I.e in the admin: No route found for "GET /en/admin/en/core/get-short-object-description"
|
Hi, Any possibility to see this PR verified soon? Thx! |
|
Can you provide a test for this? |
|
Hi @BadPixxel, are you still interested in this PR ? Could you add a unit test for this ? |
|
Hi @VincentLanglet yes still need this PR. |
|
Hi @VincentLanglet, just added few tests for this PR. Let me know if you see something I missed. |
VincentLanglet
previously approved these changes
Jul 6, 2021
core23
reviewed
Jul 6, 2021
core23
previously approved these changes
Jul 6, 2021
core23
approved these changes
Jul 6, 2021
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Site selector should not ignore Subrequests, but only metadata override.
If whole site use "host_with_path" or "host_with_path_by_locale", subrequests are rejected by router.
I.e: in the admin: No route found for "GET /en/admin/en/core/get-short-object-description"
I am targeting this branch, because this is a bugfix for 3.X versions.
Related to #1148.
Changelog