Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BlockManagerInterface #1369

Merged
merged 1 commit into from Dec 5, 2021
Merged

Add BlockManagerInterface #1369

merged 1 commit into from Dec 5, 2021

Conversation

core23
Copy link
Member

@core23 core23 commented Oct 9, 2021

Subject

Import interface from SonataBlockBundle, because there in only one implementation here.

Refs: sonata-project/SonataBlockBundle#958

I am targeting this branch, because this is BC.

Changelog

### Added
- Added `Sonata\BlockBundle\Model\BlockManagerInterface`

### Deprecated
- Deprecated `Sonata\BlockBundle\Model\BlockManagerInterface` usage

@core23 core23 added the minor label Oct 9, 2021
@core23 core23 requested a review from a team October 9, 2021 11:26
@VincentLanglet
Copy link
Member

VincentLanglet commented Oct 9, 2021 •
edited

Is this interface needed or cant we just implements both Manager and PageableManagerInterface ?

Might be also interesting to know why the PageableManagerInterface doesnt extend the ManagerInterface

@VincentLanglet VincentLanglet mentioned this pull request Oct 9, 2021
Closed
@VincentLanglet
Copy link
Member

Since all the getPager method seems deprecated in this project, I think adding a BlockManagerInterface is not needed, it just need to be abandon in favor of the ManagerInterface

@core23 core23 force-pushed the block-manager branch 2 times, most recently from ee09ece to c5ab1bd Compare October 9, 2021 15:18
@core23
Copy link
Member Author

core23 commented Oct 9, 2021

Reworked this PR. The interface will now contain all public methods from the BlockManager.

@core23 core23 mentioned this pull request Oct 11, 2021
Merged
@core23 core23 force-pushed the block-manager branch 2 times, most recently from 47f0541 to 9545127 Compare October 14, 2021 18:59
@core23 core23 requested review from a team and VincentLanglet October 14, 2021 18:59
VincentLanglet
VincentLanglet previously approved these changes Oct 14, 2021
View reviewed changes
@VincentLanglet VincentLanglet requested a review from a team October 14, 2021 19:28
@core23 core23 requested a review from a team December 4, 2021 19:21
@jordisala1991 jordisala1991 merged commit d102ce8 into sonata-project:3.x Dec 5, 2021
@jordisala1991
Copy link
Member

Thanks @core23

@core23 core23 deleted the block-manager branch December 5, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@core23 @VincentLanglet @jordisala1991